<html>
<head><meta charset="utf-8"><title>Reviving `ptr::eq` lint · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviving.20.60ptr.3A.3Aeq.60.20lint.html">Reviving `ptr::eq` lint</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="212532971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviving%20%60ptr%3A%3Aeq%60%20lint/near/212532971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Bruno BELANYI <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviving.20.60ptr.3A.3Aeq.60.20lint.html#212532971">(Oct 07 2020 at 09:20)</a>:</h4>
<p>Hello, I wanted to tackle this issue as my first contribution to Clippy : <a href="https://github.com/rust-lang/rust-clippy/issues/3661">https://github.com/rust-lang/rust-clippy/issues/3661</a><br>
There is an old PR that wasn't merged due to inactivity, so I tried to use its code as a basis for a new PR. However there has been an update in the fields of <code>LateContext</code>, and I would like to know how to do the appropriate modifications (the <code>tables</code> field doesn't exist, so we can't use <code>tables.exp_ty()</code>).</p>



<a name="212533488"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviving%20%60ptr%3A%3Aeq%60%20lint/near/212533488" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Bruno BELANYI <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviving.20.60ptr.3A.3Aeq.60.20lint.html#212533488">(Oct 07 2020 at 09:25)</a>:</h4>
<p>Mmh actually scratch that, I think I found it after reviewing the common tools document :-)</p>



<a name="212535529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviving%20%60ptr%3A%3Aeq%60%20lint/near/212535529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Bruno BELANYI <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviving.20.60ptr.3A.3Aeq.60.20lint.html#212535529">(Oct 07 2020 at 09:47)</a>:</h4>
<p>Well I have opened my first PR on Clippy <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span>. Thank you for being my rubber ducks in this small experiment :-)</p>



<a name="212536950"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviving%20%60ptr%3A%3Aeq%60%20lint/near/212536950" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Bruno BELANYI <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviving.20.60ptr.3A.3Aeq.60.20lint.html#212536950">(Oct 07 2020 at 10:03)</a>:</h4>
<p>I also opened a small PR to update the docs that still referred to the <code>tables</code> field in <code>LateContext</code>.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>